-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-113234: Add remaining TOML types to conversation table #113236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There's value in matching the TOML spec, and technically-redundant entries won't hurt. (For sufficiently advanced users, all of the table falls under “common sense” anyway...) Given that the spec lists these types last, and they're technically redundant (so, less important to document), could you move them to the end of the table? Maybe it would be best to then try to match the spec even more. (The spec has a well-thought ordering, IMO!):
@hukkin & @hauntsaninja, any opinions? |
Per @encukou's suggestion, add the "TOML document" type and then reorder all rows to match the TOML spec. See PR comment for details: python#113236 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable enough to me! :-)
Thanks @ryan-duve for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-113283 is a backport of this pull request to the 3.12 branch. |
…ng types (pythonGH-113236) (cherry picked from commit 76d757b) Co-authored-by: ryan-duve <[email protected]>
GH-113284 is a backport of this pull request to the 3.11 branch. |
…ng types (pythonGH-113236) (cherry picked from commit 76d757b) Co-authored-by: ryan-duve <[email protected]>
@ryan-duve Congratulations and thank you for your first CPython PR! 🎉 |
Resolves #113234
This adds two entries to the documentation for the conversion table for TOML.
📚 Documentation preview 📚: https://cpython-previews--113236.org.readthedocs.build/