-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-101100: Fix Py_DEBUG dangling references #115003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems like this PR also includes all the changes from your unrelated other PR: Was that intentional? Perhaps you had your branch for that PR checked out, instead of your |
sigh I just branched from my main. Apologies. Not sure how to proceed at this point. |
I fixed things up for you by pushing to your branch (you'll have to I don't work much with the C API, so I don't have strong opinions on the C API docs -- it'd be great if @serhiy-storchaka might be able to take a look at this one |
Oh, maybe it's complaining about the section below the message, not above it. |
Too late. I will revert it if it's a deal breaker, but I see no reason that it needs to actually be documented in Python's documentation. |
I don't think it's a deal-breaker :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add the Py_DEBUG
macro to the index.
Add the .. macro:: Py_DEBUG
directive, look what index is generated for it, and add the same index with the .. index::
directive.
…ther references and an index entry.
@serhiy-storchaka I added an explicit While I was at it, I simplified the text in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks @smontanaro for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…5003) (cherry picked from commit d0322fd) Co-authored-by: Skip Montanaro <[email protected]>
Sorry, @smontanaro and @AlexWaygood, I could not cleanly backport this to
|
GH-115135 is a backport of this pull request to the 3.12 branch. |
GH-115141 is a backport of this pull request to the 3.11 branch. |
Per conversation with @AlexWaygood, here is a small proposed fix to a few broken Py_DEBUG links. My suggestion was to reference the
_debug-build
anchor. Aside from that, all this does so far is suppress danglingPy_DEBUG
references in the same paragraphs where the_debug-build
anchor is referenced.📚 Documentation preview 📚: https://cpython-previews--115003.org.readthedocs.build/