gh-115264: Fix test_functools with -00 mode
#115276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
changed the title
test_functools with -00 modetest_functools with -00 mode
|
Unrelated failure reported: #116455 |
AlexWaygood
approved these changes
Mar 7, 2024
Comment on lines
3136
to
+3140
| def test_doc(self): | ||
| self.assertEqual(CachedCostItem.cost.__doc__, "The cost of the item.") | ||
| self.assertEqual(CachedCostItem.cost.__doc__, | ||
| ("The cost of the item." | ||
| if support.HAVE_DOCSTRINGS | ||
| else None)) |
There was a problem hiding this comment.
Or should this whole test just be skipped if we're in -00 mode, maybe?
There was a problem hiding this comment.
I think that checking that docstring is stripped in -OO is also helpful. So, I prefer to not skip it.
There was a problem hiding this comment.
Sure. I don't have a strong opinion either way -- feel free to merge :)
sobolevn
added
needs backport to 3.11
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 27df81d) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-116706 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 27df81d) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-116707 is a backport of this pull request to the 3.12 branch. |
sobolevn
added a commit
that referenced
this pull request
Mar 13, 2024
sobolevn
added a commit
that referenced
this pull request
Mar 13, 2024
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the tests pass with both modes.
test_functoolsfails when run with-OO#115264