Skip to content

gh-116404: Handle errors correctly in wait_helper in posixmodule #116405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 6, 2024

This would need backports to 3.12 and 3.11: https://github.com/python/cpython/blob/3.11/Modules/posixmodule.c#L8395-L8426

I've also noticed really strange refleak output (it is the same before and after):

» ./python.exe -m test -R 3:3 test_wait4 test_wait3 
Using random seed: 3926646517
0:00:00 load avg: 1.33 Run 2 tests sequentially
0:00:00 load avg: 1.33 [1/2] test_wait4
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX. .1.
test_wait4 leaked [-1, 1, 0] memory blocks, sum=0 (this is fine)
0:00:30 load avg: 1.71 [2/2] test_wait3 -- test_wait4 passed in 30.5 sec
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX. ...
test_wait3 passed in 30.6 sec

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 1 min 1 sec
Total tests: run=5
Total test files: run=2/2
Result: SUCCESS

@sobolevn sobolevn enabled auto-merge (squash) March 6, 2024 08:23
@sobolevn sobolevn merged commit 22ccf13 into python:main Mar 6, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2024
…dule` (pythonGH-116405)

(cherry picked from commit 22ccf13)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 6, 2024

GH-116406 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2024
…dule` (pythonGH-116405)

(cherry picked from commit 22ccf13)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 6, 2024

GH-116407 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 6, 2024
sobolevn added a commit that referenced this pull request Mar 6, 2024
…odule` (GH-116405) (#116406)

gh-116404: Handle errors correctly in `wait_helper` in `posixmodule` (GH-116405)
(cherry picked from commit 22ccf13)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this pull request Mar 6, 2024
…odule` (GH-116405) (#116407)

gh-116404: Handle errors correctly in `wait_helper` in `posixmodule` (GH-116405)
(cherry picked from commit 22ccf13)

Co-authored-by: Nikita Sobolev <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants