gh-116484: Fix collisions between Checkbutton and ttk.Checkbutton default names

[serhiy-storchaka]

Change automatically generated tkinter.Checkbutton widget names to avoid collisions with automatically generated tkinter.ttk.Checkbutton widget names within the same parent widget.

• Issue: tkinter breaks when mixing tk.Checkbutton and ttk.Checkbutton #116484

[terryjreedy]

I read the diff but want to look at more of the tk/ttk code before commenting. Will try to do so after mentor meeting tomorrow.

[BartolHrg]

The proposed solution is to add "_" in-between"!checkbutton" and the number (e.g. "!checkbutton_2").
But there might be a problem if someone names some class Checkbutton_

You might want to consider using some character that cannot be used in a Python variable name like '-' ("!checkbutton-2")

[terryjreedy]

While I think a user is more likely to define Checkbutton_ than Checkbutton, I think doing so without either inheriting from tk.Checkbutton or defining .setup could be considered buggy. Still, adding '-' instead of '' is fine with me unless there is a reason against that I cannot think of.

I otherwise approve of the patch.

[serhiy-storchaka]

You might want to consider using some character that cannot be used in a Python variable name like '-' ("!checkbutton-2")

Good point. Even if this is not very likely, it is better to be safe.

[miss-islington-app]

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

[bedevere-app]

GH-116901 is a backport of this pull request to the 3.12 branch.

[bedevere-app]

GH-116902 is a backport of this pull request to the 3.11 branch.