gh-115538: Using pathlib to compare prefixes in test_venv #117076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Azure's PPA server seems down now.😢 |
|
Looks like it's launchpad, which hosts the PPA with gdb on it, but yeah definitely down. At least the Windows tests passed :) |
zooba
approved these changes
Mar 20, 2024
|
@zooba Hi, can we merge this now? I see there's no more review comments since you approved it. And I see the related PRs for the original issue were backported to 3.10 and 3.11, so It think this should backported too, so I updated the label. |
zooba
added
needs backport to 3.11
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2024
…GH-117076) (cherry picked from commit 52f5b7f) Co-authored-by: AN Long <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2024
…GH-117076) (cherry picked from commit 52f5b7f) Co-authored-by: AN Long <[email protected]>
|
GH-117461 is a backport of this pull request to the 3.12 branch. |
|
GH-117462 is a backport of this pull request to the 3.11 branch. |
zooba
pushed a commit
that referenced
this pull request
Apr 2, 2024
…7076) gh-115538: Use pathlib to compare prefixes in test_venv (GH-117076) (cherry picked from commit 52f5b7f) Co-authored-by: AN Long <[email protected]>
zooba
pushed a commit
that referenced
this pull request
Apr 2, 2024
…7076) gh-115538: Use pathlib to compare prefixes in test_venv (GH-117076) (cherry picked from commit 52f5b7f) Co-authored-by: AN Long <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.