Skip to content

GH-117536: ensure asyncgens GCd before runner teardown get aclosed #117577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

GH-117536: ensure asyncgens GCd before runner teardown get aclosed #117577

wants to merge 1 commit into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Apr 6, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 6, 2024
Closed
@graingert
Copy link
Contributor Author

some tests needed:

  • an async gen getting GCd during teardown can call await asyncio.sleep(0) without raising GeneratorExit
  • an async gen getting GCd after shutdown_asyncgens is called can call await asyncio.sleep(0) without getting GeneratorExit

graingert
graingert commented Apr 6, 2024
View reviewed changes
Lib/asyncio/base_events.py
@@ -573,13 +585,18 @@ async def shutdown_asyncgens(self):
"""Shutdown all active asynchronous generators."""
self._asyncgens_shutdown_called = True

if not len(self._asyncgens):
closing_agens = list(self._asyncgens)
closing_agens.extend(self._closing_asyncgens.copy())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
closing_agens.extend(self._closing_asyncgens.copy())
closing_agens.extend(self._closing_asyncgens)

@graingert
Copy link
Contributor Author

My original diagnosis of the problem was wrong, async gens .aclose() get cancelled but still scheduled

@graingert graingert closed this Apr 10, 2024
@graingert graingert deleted the ensure-asyncgens-gcd-before-runner-teardown-get-aclosed branch April 10, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

Assignees
No one assigned
Labels
topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @gvanrossum