Skip to content

gh-117613: Argument Clinic: disallow defining_class parameter at module level #117950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 17, 2024
Merged

gh-117613: Argument Clinic: disallow defining_class parameter at module level #117950

merged 8 commits into from
Apr 17, 2024

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Apr 16, 2024 •
edited by bedevere-app bot
Loading

@neonene neonene requested a review from erlend-aasland as a code owner April 16, 2024 21:46
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2024
Closed
vstinner
vstinner reviewed Apr 16, 2024
View reviewed changes
@neonene neonene changed the title gh-117613: Argument Clinic: disallow defining_class parameter inside a module block gh-117613: Argument Clinic: disallow defining_class parameter at module level Apr 16, 2024
@neonene neonene mentioned this pull request Apr 16, 2024
Merged
@neonene
Copy link
Contributor Author

neonene commented Apr 16, 2024

I cannot investigate the mypy error right now, failing to build mypy on 3.13.

@erlend-aasland
Copy link
Contributor

I cannot investigate the mypy error right now, failing to build mypy on 3.13.

I can take a look. Would you like me to update the PR for you?

vstinner
vstinner approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neonene
Copy link
Contributor Author

neonene commented Apr 17, 2024

Thank you. I just managed to install mypy. I'll try it a bit more.

@neonene
Copy link
Contributor Author

neonene commented Apr 17, 2024

Please check.

erlend-aasland
erlend-aasland reviewed Apr 17, 2024
View reviewed changes
@erlend-aasland
Copy link
Contributor

Thank you, @neonene and @vstinner!

@erlend-aasland erlend-aasland merged commit c1d7147 into python:main Apr 17, 2024
@neonene neonene deleted the ac313 branch April 18, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonene @erlend-aasland @vstinner