Skip to content

gh-118119: Re-use sep in posixpath.expanduser() #118120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

gh-118119: Re-use sep in posixpath.expanduser() #118120

merged 1 commit into from
May 7, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 20, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 20, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review April 20, 2024 07:20
@nineteendo
Copy link
Contributor Author

Could someone add the skip-news label? Thank you.

@serhiy-storchaka
Copy link
Member

This code used sep in the past, but for some reasons it was replaced with root in ef3e4c2. This cumulative change included a port of r71241 (3f0ef20) which fixed bpo-5471. cc @birkenfeld, @benjaminp

@birkenfeld
Copy link
Member

Whatever the motivation back then, this being posixpath sep is guaranteed to be "/" so I don't see a problem with the change.

@nineteendo
Copy link
Contributor Author

@birkenfeld, could you approve this then?

@encukou encukou merged commit 6f768b7 into python:main May 7, 2024
35 checks passed
@nineteendo nineteendo deleted the refactor-posixpath.expanduser branch May 7, 2024 10:51
@nineteendo
Copy link
Contributor Author

Thanks @encukou.

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@nineteendo @SonicField
pythongh-118119: Re-use sep in posixpath.expanduser() (pythonGH-1…
f4dc046 
…18120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@birkenfeld birkenfeld Awaiting requested review from birkenfeld

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nineteendo @serhiy-storchaka @birkenfeld @encukou @erlend-aasland