Skip to content

Fix note in Enum.__new__ docs #118284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix note in Enum.__new__ docs #118284

merged 2 commits into from
Apr 26, 2024

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Apr 25, 2024

Was introduced in #116065

Should be backported to 3.12


📚 Documentation preview 📚: https://cpython-previews--118284.org.readthedocs.build/en/118284/library/enum.html#enum.Enum.__new__

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 25, 2024
@flying-sheep
Copy link
Contributor Author

flying-sheep commented Apr 25, 2024

While we’re at it: value and _value_ both say

Value of the member, can be set in __new__().

where the link goes to object.__new__.

Should we update these links to go to Enum.__new__ instead?

@JelleZijlstra
Copy link
Member

Yes, let's fix the link to __new__ too.

@JelleZijlstra JelleZijlstra merged commit 5a4d3df into python:main Apr 26, 2024
27 checks passed
@miss-islington-app
Copy link

Thanks @flying-sheep for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @flying-sheep and @JelleZijlstra, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5a4d3df2fa02409ffd2a90cd75b67370206e9891 3.12

@bedevere-app
Copy link

bedevere-app bot commented Apr 26, 2024

GH-118325 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 26, 2024
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Apr 26, 2024
(cherry picked from commit 5a4d3df)

Co-authored-by: Philipp A <[email protected]>
@flying-sheep flying-sheep deleted the patch-1 branch April 26, 2024 15:24
JelleZijlstra added a commit that referenced this pull request Apr 26, 2024
(cherry picked from commit 5a4d3df)

Co-authored-by: Philipp A <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants