-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-117139: Add header for tagged pointers #118330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
209ddac
Add header for tagged pointers
Fidget-Spinner f783bc4
cleanup
Fidget-Spinner 4c52acc
end EOL
Fidget-Spinner 9e0ed42
fix warnings
Fidget-Spinner 4610cac
format
Fidget-Spinner f0df2bc
make macro names more symmetrical
Fidget-Spinner 35ac0ce
fix warning
Fidget-Spinner c08a6f5
address rest of review
Fidget-Spinner 9b5f8b2
remove MAX_UNTAG_SCRATCH
Fidget-Spinner 046e308
rename file
Fidget-Spinner 1a7087e
rename header guards
Fidget-Spinner 2090980
add xnewref
Fidget-Spinner 2f50bcb
Add Py_STACKREF_NULL
Fidget-Spinner 5961992
fix Windows build
Fidget-Spinner 6bf6d44
try fix Windows for real this time
Fidget-Spinner 003d274
address review
Fidget-Spinner 7501357
revert hasdeferred refcount back to original file
Fidget-Spinner 53608d7
remove decref_owned
Fidget-Spinner 0131fc1
address review
Fidget-Spinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,195 @@ | ||
#ifndef Py_INTERNAL_STACKREF_H | ||
#define Py_INTERNAL_STACKREF_H | ||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
#ifndef Py_BUILD_CORE | ||
# error "this header requires Py_BUILD_CORE define" | ||
#endif | ||
|
||
#include <stddef.h> | ||
|
||
typedef union { | ||
uintptr_t bits; | ||
} _PyStackRef; | ||
|
||
static const _PyStackRef Py_STACKREF_NULL = { .bits = 0 }; | ||
|
||
#define Py_TAG_DEFERRED (1) | ||
|
||
// Gets a PyObject * from a _PyStackRef | ||
#if defined(Py_GIL_DISABLED) | ||
static inline PyObject * | ||
PyStackRef_Get(_PyStackRef tagged) | ||
{ | ||
PyObject *cleared = ((PyObject *)((tagged).bits & (~Py_TAG_DEFERRED))); | ||
return cleared; | ||
} | ||
#else | ||
# define PyStackRef_Get(tagged) ((PyObject *)((tagged).bits)) | ||
#endif | ||
|
||
// Converts a PyObject * to a PyStackRef, stealing the reference. | ||
#if defined(Py_GIL_DISABLED) | ||
static inline _PyStackRef | ||
_PyStackRef_StealRef(PyObject *obj) | ||
{ | ||
// Make sure we don't take an already tagged value. | ||
assert(((uintptr_t)obj & Py_TAG_DEFERRED) == 0); | ||
return ((_PyStackRef){.bits = ((uintptr_t)(obj))}); | ||
} | ||
# define PyStackRef_StealRef(obj) _PyStackRef_StealRef(_PyObject_CAST(obj)) | ||
#else | ||
# define PyStackRef_StealRef(obj) ((_PyStackRef){.bits = ((uintptr_t)(obj))}) | ||
#endif | ||
|
||
// Converts a PyObject * to a PyStackRef, with a new reference | ||
#if defined(Py_GIL_DISABLED) | ||
static inline _PyStackRef | ||
_PyStackRef_NewRefDeferred(PyObject *obj) | ||
{ | ||
// Make sure we don't take an already tagged value. | ||
assert(((uintptr_t)obj & Py_TAG_DEFERRED) == 0); | ||
assert(obj != NULL); | ||
if (_PyObject_HasDeferredRefcount(obj)) { | ||
return (_PyStackRef){ .bits = (uintptr_t)obj | Py_TAG_DEFERRED }; | ||
} | ||
else { | ||
return (_PyStackRef){ .bits = (uintptr_t)Py_NewRef(obj) }; | ||
} | ||
} | ||
# define PyStackRef_NewRefDeferred(obj) _PyStackRef_NewRefDeferred(_PyObject_CAST(obj)) | ||
#else | ||
# define PyStackRef_NewRefDeferred(obj) PyStackRef_NewRef(((_PyStackRef){.bits = ((uintptr_t)(obj))})) | ||
#endif | ||
|
||
#if defined(Py_GIL_DISABLED) | ||
static inline _PyStackRef | ||
_PyStackRef_XNewRefDeferred(PyObject *obj) | ||
{ | ||
// Make sure we don't take an already tagged value. | ||
assert(((uintptr_t)obj & Py_TAG_DEFERRED) == 0); | ||
if (obj == NULL) { | ||
return Py_STACKREF_NULL; | ||
} | ||
return _PyStackRef_NewRefDeferred(obj); | ||
} | ||
# define PyStackRef_XNewRefDeferred(obj) _PyStackRef_XNewRefDeferred(_PyObject_CAST(obj)) | ||
#else | ||
# define PyStackRef_XNewRefDeferred(obj) PyStackRef_XNewRef(((_PyStackRef){.bits = ((uintptr_t)(obj))})) | ||
#endif | ||
|
||
// Converts a PyStackRef back to a PyObject *. | ||
#if defined(Py_GIL_DISABLED) | ||
static inline PyObject * | ||
PyStackRef_StealObject(_PyStackRef tagged) | ||
{ | ||
if ((tagged.bits & Py_TAG_DEFERRED) == Py_TAG_DEFERRED) { | ||
assert(_PyObject_HasDeferredRefcount(PyStackRef_Get(tagged))); | ||
return Py_NewRef(PyStackRef_Get(tagged)); | ||
} | ||
return PyStackRef_Get(tagged); | ||
} | ||
#else | ||
# define PyStackRef_StealObject(tagged) PyStackRef_Get(tagged) | ||
#endif | ||
|
||
static inline void | ||
_Py_untag_stack_borrowed(PyObject **dst, const _PyStackRef *src, size_t length) | ||
{ | ||
for (size_t i = 0; i < length; i++) { | ||
dst[i] = PyStackRef_Get(src[i]); | ||
} | ||
} | ||
|
||
static inline void | ||
_Py_untag_stack_steal(PyObject **dst, const _PyStackRef *src, size_t length) | ||
{ | ||
for (size_t i = 0; i < length; i++) { | ||
dst[i] = PyStackRef_StealObject(src[i]); | ||
} | ||
} | ||
|
||
|
||
#define PyStackRef_XSETREF(dst, src) \ | ||
do { \ | ||
_PyStackRef *_tmp_dst_ptr = &(dst) \ | ||
_PyStackRef _tmp_old_dst = (*_tmp_dst_ptr); \ | ||
*_tmp_dst_ptr = (src); \ | ||
PyStackRef_XDECREF(_tmp_old_dst); \ | ||
} while (0) | ||
|
||
#define PyStackRef_SETREF(dst, src) \ | ||
do { \ | ||
_PyStackRef *_tmp_dst_ptr = &(dst); \ | ||
_PyStackRef _tmp_old_dst = (*_tmp_dst_ptr); \ | ||
*_tmp_dst_ptr = (src); \ | ||
PyStackRef_DECREF(_tmp_old_dst); \ | ||
} while (0) | ||
|
||
#define PyStackRef_CLEAR(op) \ | ||
do { \ | ||
_PyStackRef *_tmp_op_ptr = &(op); \ | ||
_PyStackRef _tmp_old_op = (*_tmp_op_ptr); \ | ||
if (_tmp_old_op.bits != Py_STACKREF_NULL.bits) { \ | ||
*_tmp_op_ptr = Py_STACKREF_NULL; \ | ||
PyStackRef_DECREF(_tmp_old_op); \ | ||
} \ | ||
} while (0) | ||
|
||
#if defined(Py_GIL_DISABLED) | ||
static inline void | ||
PyStackRef_DECREF(_PyStackRef tagged) | ||
{ | ||
if ((tagged.bits & Py_TAG_DEFERRED) == Py_TAG_DEFERRED) { | ||
return; | ||
} | ||
Py_DECREF(PyStackRef_Get(tagged)); | ||
} | ||
#else | ||
# define PyStackRef_DECREF(op) Py_DECREF(PyStackRef_Get(op)) | ||
#endif | ||
|
||
#if defined(Py_GIL_DISABLED) | ||
static inline void | ||
PyStackRef_INCREF(_PyStackRef tagged) | ||
{ | ||
if ((tagged.bits & Py_TAG_DEFERRED) == Py_TAG_DEFERRED) { | ||
assert(_PyObject_HasDeferredRefcount(PyStackRef_Get(tagged))); | ||
return; | ||
} | ||
Py_INCREF(PyStackRef_Get(tagged)); | ||
} | ||
#else | ||
# define PyStackRef_INCREF(op) Py_INCREF(PyStackRef_Get(op)) | ||
#endif | ||
|
||
static inline void | ||
PyStackRef_XDECREF(_PyStackRef op) | ||
{ | ||
if (op.bits != Py_STACKREF_NULL.bits) { | ||
PyStackRef_DECREF(op); | ||
} | ||
} | ||
|
||
static inline _PyStackRef | ||
PyStackRef_NewRef(_PyStackRef obj) | ||
{ | ||
PyStackRef_INCREF(obj); | ||
return obj; | ||
} | ||
|
||
static inline _PyStackRef | ||
PyStackRef_XNewRef(_PyStackRef obj) | ||
{ | ||
if (obj.bits == Py_STACKREF_NULL.bits) { | ||
return obj; | ||
} | ||
return PyStackRef_NewRef(obj); | ||
} | ||
|
||
#ifdef __cplusplus | ||
} | ||
#endif | ||
#endif /* !Py_INTERNAL_STACKREF_H */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a missing semicolon here but I don't want to waste CI resources, so I will fix this in another PR, since nothing is using this file at the moment anyways.