-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Small fix for gdb/libpython.py docs #118438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just accidentally noticed that it was mentioning `PyIntObject *` type which is deprecated - replaced it with `PyLongObject *`. Also replaced "ob_ival" with "long_value" - similar field that's used in `PyLongObjectPtr.proxyval`.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We also should update this line: cpython/Tools/gdb/libpython.py Line 870 in 4a5ad84
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me! Thanks.
|
Buildbot failure unrelated; probably related to #118444 |
Just accidentally noticed that it was mentioning
PyIntObject *
type which is deprecated - replaced it withPyLongObject *
. Also replaced "ob_ival" with "long_value" - similar field that's used inPyLongObjectPtr.proxyval
.