-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-85453: Fix 'time zone' spelling issues across datetime.rst #118449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think timezone is also an acceptable spelling, if that's what we've been consistently using, we should probably continue using that. Alternatively, we could differentiate between |
I'm not sure... the IANA database uses "time zone" and both Wikipedia and The Free Dictionary redirect "timezone" to "time zone"... so maybe "timezone" isn't even valid spelling but people use it anyway?
Yes, I tried to differentiate all of them (the class and the instances and objects of the class) from the abstract concept. |
Hello @erlend-aasland, any issues with this PR? |
@uatach, I'll have a look in the next couple of days. |
I think it would be an improvement to consistently use spell it "time zone" in the prose; it would help separate the class from the abstract concept even more. Both spelling variants are used across the Python docs; I think we would benefit from a consistent spelling all across the docs. Moreover, most dictionaries seem to use "time zone", and as long as that is true, we're bound to get "spelling correction PRs" from time to time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; I believe this is an improvement. I'll await a few days before landing to give Paul time to chime in, in case he really don't want this to go in.
I created a "time zone" entry in the style guide: python/devguide#1352 |
Should we also recommend "date and time", or is "datetime" better because it's compact and people will understand what we mean? |
With the "time zone" / "timezone" clarification in place, it would also make sense to clarify "datetime" / "date and time", IMO. |
Anyway, I read python/devguide#1352 as a blessing from the EB to go forth with this PR. Sorry it took so long to land this, @uatach; thanks for your good work! |
This comment was marked as outdated.
This comment was marked as outdated.
…etime.rst (pythonGH-118449) (cherry picked from commit 1755df7) Co-authored-by: edson duarte <[email protected]>
GH-121837 is a backport of this pull request to the 3.13 branch. |
…etime.rst (pythonGH-118449) (cherry picked from commit 1755df7) Co-authored-by: edson duarte <[email protected]>
GH-121838 is a backport of this pull request to the 3.12 branch. |
…tetime.rst (GH-118449) (#121838) (cherry picked from commit 1755df7) Co-authored-by: edson duarte <[email protected]>
…tetime.rst (GH-118449) (#121837) (cherry picked from commit 1755df7) Co-authored-by: edson duarte <[email protected]>
Another pull request based on PR #21447, this one focused on fixing spelling issues on occurrences of 'time zone'.
📚 Documentation preview 📚: https://cpython-previews--118449.org.readthedocs.build/