Skip to content

[3.12] GH-117714: implement athrow().close() and asend().close() using throw (GH-117906) #118663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miss-islington
Copy link
Contributor

Co-authored-by: Petr Viktorin [email protected]


(cherry picked from commit e5c6992)

Co-authored-by: Thomas Grainger [email protected]
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Petr Viktorin [email protected]

… throw (pythonGH-117906)

* pythonGH-117714: replace athrow().close() and asend().close() stubs with implimentations

* test athrow().close() and asend().close() raises RuntimeError

* 📜🤖 Added by blurb_it.

* Update Objects/genobject.c

Co-authored-by: Petr Viktorin <[email protected]>

---------

(cherry picked from commit e5c6992)

Co-authored-by: Thomas Grainger <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Petr Viktorin <[email protected]>
@graingert
Copy link
Contributor

I'm not sure if this is ok to backport, as it's a bugfix that resolves an omission

@encukou
Copy link
Member

encukou commented May 7, 2024

It changes behaviour, and I don't think fixing this bug is particularly important.
Probably best to not backport it.

@graingert
Copy link
Contributor

Sounds good

@graingert graingert closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants