Skip to content

gh-118875: Update tarfile.extractall and friends to use filter="data" by default #118940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gh-118875: Update tarfile.extractall and friends to use filter="data" by default #118940

wants to merge 1 commit into from
+18 −44

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented May 11, 2024 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 11, 2024
Closed
@edgarrmondragon edgarrmondragon changed the title gh-118798: Update tarfile.extractall and friends to use filter="data" by default gh-118875: Update tarfile.extractall and friends to use filter="data" by default May 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 11, 2024
Open
@nineteendo
Copy link
Contributor

nineteendo commented May 11, 2024 •
edited
Loading

You still need to update theses tests:

  • test.test_shutil.TestArchives.test_unpack_archive_bztar
  • test.test_shutil.TestArchives.test_unpack_archive_gztar
  • test.test_shutil.TestArchives.test_unpack_archive_tar
  • test.test_shutil.TestArchives.test_unpack_archive_xztar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman will be requested when the pull request is marked ready for review ethanfurman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @nineteendo