gh-120164: Fix test_os.test_win32_mkdir_700
#120177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
added
needs backport to 3.12
|
LGTM. I assume it works on your machine? |
Yes, it is. |
vstinner
reviewed
Jun 7, 2024
Co-authored-by: Eryk Sun <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2024
Don't compare the path to avoid encoding issues. (cherry picked from commit d5ba4fc) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Eryk Sun <[email protected]>
|
GH-120202 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2024
Don't compare the path to avoid encoding issues. (cherry picked from commit d5ba4fc) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Eryk Sun <[email protected]>
|
GH-120203 is a backport of this pull request to the 3.12 branch. |
|
Merged, thanks for the fix @Eclips4. |
vstinner
pushed a commit
that referenced
this pull request
Jun 7, 2024
…0203) gh-120164: Fix test_os.test_win32_mkdir_700() (GH-120177) Don't compare the path to avoid encoding issues. (cherry picked from commit d5ba4fc) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Eryk Sun <[email protected]>
vstinner
pushed a commit
that referenced
this pull request
Jun 7, 2024
…0202) gh-120164: Fix test_os.test_win32_mkdir_700() (GH-120177) Don't compare the path to avoid encoding issues. (cherry picked from commit d5ba4fc) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Eryk Sun <[email protected]>
|
Thanks for the reviews! |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Don't compare the path to avoid encoding issues. Co-authored-by: Eryk Sun <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Don't compare the path to avoid encoding issues. Co-authored-by: Eryk Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_os.test_win32_mkdir_700fails on Windows #120164