Skip to content

gh-120226: Enlarge DATA to make test_sendfile_close_peer_in_the_middl… #120227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

gh-120226: Enlarge DATA to make test_sendfile_close_peer_in_the_middl… #120227

merged 1 commit into from
Jun 7, 2024

Conversation

xry111
Copy link
Contributor

@xry111 xry111 commented Jun 7, 2024 •
edited by bedevere-app bot
Loading

@xry111
pythongh-120226: Enlarge DATA to make test_sendfile_close_peer_in_the…
431c046 
…_middle_of_receiving happy with non-4KiB page and Linux >= 6.10
@ghost
Copy link

ghost commented Jun 7, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Jun 7, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 7, 2024
Closed
gvanrossum
gvanrossum approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this.

@gvanrossum gvanrossum merged commit a758424 into python:main Jun 7, 2024
36 checks passed
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@xry111 @noahbkim
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
aca0195 
…ing on Linux >= 6.10 (python#120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@xry111 @estyxx
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
d9b3072 
…ing on Linux >= 6.10 (python#120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Aug 28, 2024
@miss-islington-app
Copy link

Thanks @xry111 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2024
@xry111 @miss-islington
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
1b3f652 
…ing on Linux >= 6.10 (pythonGH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 28, 2024

GH-123421 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 28, 2024
@vstinner vstinner added the needs backport to 3.12 only security fixes label Aug 28, 2024
@miss-islington-app
Copy link

Thanks @xry111 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2024
@xry111 @miss-islington
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
1d684d4 
…ing on Linux >= 6.10 (pythonGH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 28, 2024

GH-123422 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 28, 2024
@vstinner
Copy link
Member

Python 3.12 and 3.13 are also affected. I created backports.

vstinner pushed a commit that referenced this pull request Aug 28, 2024
@miss-islington @xry111
[3.12] gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_recei…
ccc6c2b 
…ving on Linux >= 6.10 (GH-120227) (#123422)

gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiving on Linux >= 6.10 (GH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
@miss-islington @xry111
[3.13] gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_recei…
14a899f 
…ving on Linux >= 6.10 (GH-120227) (#123421)

gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiving on Linux >= 6.10 (GH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xry111 @vstinner @gvanrossum