-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-120397: improve the speed of str.count, bytes.count et al. for single characters by about 2x. #120398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
gh-120397: improve the speed of str.count, bytes.count et al. for single characters by about 2x. #120398
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b2f9fb5
Faster counting of characters due to autovectorization
rhpvorderman cb56443
Add blurb entry for faster count method
rhpvorderman fff610b
Rewrite count function as a for loop
rhpvorderman 1359366
Do the max count check in the inner loop
rhpvorderman 5837e41
Remove extraneous newline
rhpvorderman c6f4068
Add an explanatory comment
rhpvorderman 0eaccd5
Revert changes
rhpvorderman a85202c
Use a no maximum count function
rhpvorderman 807706d
Update Misc/NEWS.d/next/Core and Builtins/2024-06-12-13-47-25.gh-issu…
rhpvorderman fb83c6a
Formatting
rhpvorderman 05a1fc2
Give a speed indication
rhpvorderman 2fab99b
Update comment
rhpvorderman ce9ab9b
rename function
rhpvorderman 0cc9369
Update Objects/stringlib/fastsearch.h
vstinner 30a65a7
Fix changing oversights
rhpvorderman a16c7ec
Merge branch 'fastercount' of github.com:rhpvorderman/cpython into fa…
rhpvorderman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core and Builtins/2024-06-12-13-47-25.gh-issue-120397.n-I_cc.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Improve the througput by up to two times for the :meth:`str.count`, :meth:`bytes.count` and :meth:`bytearray.count` | ||
methods for counting single characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maxcount is only used in the replace function, it is very unlikely that this condition will ever be triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but there's no reason to check for
PY_SSIZE_T_MAX
specifically when this works as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are correct. However, this function needs some refactoring, as this maxcount provision is only there for replace. Replace for single characters is special.cased elsewhere, so maxcount is actually always Pyssize_t_max I think. I want to revisit this at a later point.