gh-120417: Add #noqa: F401 to tests #120627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
picnixz
approved these changes
Jun 17, 2024
Comment on lines
104
to
+106
| # In case _socket fails to build, make this test fail more gracefully | ||
| # than an AttributeError somewhere deep in concurrent.futures, email | ||
| # or unittest. | ||
| import _socket | ||
| import _socket # noqa: F401 |
There was a problem hiding this comment.
Would not using import_module() be better?
There was a problem hiding this comment.
The intent is to get an error if the module is missing, not to skip the test.
| @@ -18,7 +18,7 @@ | |||
| # compileall relies on ProcessPoolExecutor if ProcessPoolExecutor exists | |||
| # and it can function. | |||
| from multiprocessing.util import _cleanup_tests as multiprocessing_cleanup_tests | |||
| from concurrent.futures import ProcessPoolExecutor | |||
| from concurrent.futures import ProcessPoolExecutor # noqa: F401 | |||
There was a problem hiding this comment.
Why ProcessPoolExecutor is needed?
There was a problem hiding this comment.
It's explained in the comment, 2 lines above. It's a check to define _have_multiprocessing.
| @@ -8,7 +8,7 @@ | |||
| # of much interest anymore), and a few were fiddled to make the output | |||
| # deterministic. | |||
|
|
|||
| from test.support import sortdict | |||
| from test.support import sortdict # noqa: F401 | |||
There was a problem hiding this comment.
Why sortdict is needed?
Ignore linter "imported but unused" warnings in tests when the linter doesn't understand why the import is important.
|
PR rebased to squash changes and fix merge conflicts. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jun 19, 2024
Ignore linter "imported but unused" warnings in tests when the linter doesn't understand how the import is used.
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Ignore linter "imported but unused" warnings in tests when the linter doesn't understand how the import is used.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Ignore linter "imported but unused" warnings in tests when the linter doesn't understand how the import is used.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Ignore linter "imported but unused" warnings in tests when the linter doesn't understand how the import is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore linter "imported but unused" warnings in tests when the linter doesn't understand why the import is important.