-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-121351: skip test_not_wiping_history_file() if no readline #121422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
!buildbot AMD64 FreeBSD14 |
!buildbot ARM64 MacOS M1 NoGIL |
!buildbot s390x Fedora PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But let's see if it does fix the issue on buildbots.
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ythonGH-121422) (cherry picked from commit 68e279b) Co-authored-by: Sergey B Kirpichev <[email protected]>
GH-121449 is a backport of this pull request to the 3.13 branch. |
I still see this failure on my Mac. I changed the failing test to skip it if
If you think that is the right thing to do, I will create a PR, but I'm kind of busy with some other stuff right now. Might take a couple days to get around to it. |
Here is the recent test on main: https://buildbot.python.org/#/builders/1270/builds/2021 So, I doubt it's a good idea just disable this on Mac. @smontanaro, could you, please, test original issue #121245? I worry it might be valid on your system. Is it possible that you have some PYTHON* variables defined? |
Rebuilding the Note, however, that if I unset |
See #121672 in this case. |
Uh oh!
There was an error while loading. Please reload this page.