Skip to content

gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.TestMain #121672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024
Merged

gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.TestMain #121672

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cc746c
gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.py
skirpichev Jul 13, 2024
8cd20af
patch os.environ instead
skirpichev Jul 13, 2024
77d433a
+ comment
skirpichev Jul 13, 2024
0795ba3
Don't hold onto the result of the patcher
ambv Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,19 @@ def test_bracketed_paste_single_line(self):

@skipUnless(pty, "requires pty")
class TestMain(TestCase):
def setUp(self):
# Cleanup from PYTHON* variables to isolate from local
# user settings, see #121359. Such variables should be
# added later in test methods to patched os.environ.
clean_env = os.environ.copy()
for k in clean_env.copy():
if k.startswith("PYTHON"):
clean_env.pop(k)

patcher = patch('os.environ', new=clean_env)
self.addCleanup(patcher.stop)
patcher.start()

@force_not_colorized
def test_exposed_globals_in_repl(self):
pre = "['__annotations__', '__builtins__'"
Expand Down
Loading