gh-122420: Fix accounting for immortal interned strings in refleak.py #122421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leak.py The `_PyUnicode_Intern*` functions already adjust the total refcount, so we don't want to readjust it in refleak.py.
colesbury
added
tests
|
!buildbot nogil refleak |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit bbc1ddf 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
colesbury
changed the title
|
!buildbot AMD64 RHEL8 Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit bbc1ddf 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @colesbury for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2024
…eak.py (pythonGH-122421) The `_PyUnicode_Intern*` functions already adjust the total refcount, so we don't want to readjust it in refleak.py. (cherry picked from commit ac8da34) Co-authored-by: Sam Gross <[email protected]>
|
GH-122430 is a backport of this pull request to the 3.13 branch. |
encukou
pushed a commit
that referenced
this pull request
Jul 30, 2024
…leak.py (GH-122421) (GH-122430) The `_PyUnicode_Intern*` functions already adjust the total refcount, so we don't want to readjust it in refleak.py. (cherry picked from commit ac8da34) Co-authored-by: Sam Gross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_PyUnicode_Intern*functions already adjust the total refcount, so we don't want to readjust it in refleak.py.test_internintest_sysleaks negative references in free-threaded build #122420