gh-122549: Allow to invalidate platform's cached results #122547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
kashav
suggested changes
Aug 1, 2024
vstinner
approved these changes
Aug 9, 2024
picnixz
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
I just want to be sure that build bots won't be unhappy with this change for whatever reason (we'll get the answer in roughly 8 hours) |
picnixz
commented
Nov 16, 2024
| This is typically useful when the platform's :func:`node` is changed | ||
| by an external process and one needs to retrieve the updated value. | ||
|
|
||
| .. versionadded:: 3.14 |
There was a problem hiding this comment.
I should have used a versionadded:: next here but at that time, it didn't exist yet. Not sure if this warrants an additional commit though. WDYT @vstinner
There was a problem hiding this comment.
next will be replaced with 3.14 anyway, there is no need to replace it.
There was a problem hiding this comment.
Yea but sometimes users are confused that the feature is present in the docs but not in the current release. That was the purpose of next
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
Allow to invalidate platform's cached results.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Allow to invalidate platform's cached results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a cache invalidation approach is probably better than querying the new results every time. At least, it will not cause any breaking change.
platform.invalidate_cachesfor invalidating cached results #122549📚 Documentation preview 📚: https://cpython-previews--122547.org.readthedocs.build/