Skip to content

GH-122616: Simplify LOAD_ATTR_WITH_HINT and STORE_ATTR_WITH_HINT #122620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 2, 2024

@markshannon
Copy link
Member Author

The three failures are networking issues on the emulated platforms and a hypothesis issues

@markshannon markshannon merged commit 5bd7291 into python:main Aug 5, 2024
54 of 57 checks passed
@markshannon markshannon deleted the linearize-store-attr-hint branch August 6, 2024 10:14
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@scoder
Copy link
Contributor

scoder commented Oct 18, 2024

A somewhat mysterious bug report (a failure with a Python exception) that we received in Cython under Py3.14a1 bisects to this change:
cython/cython#6426 (comment)
Apparently, it introduced a behavioural change where some object attributes are set to (or read as) None (or possibly their super class default value, i.e. not set at all) instead of the expected value. Note that this is in plain Python code when running Cython to translate one of its modules, running python cython.py Cython/Compiler/Parsing.py from a source checkout.

@markshannon
Copy link
Member Author

@scoder can you make a new CPython issue for the Cython problem?

I'd be very surprised if this PR was the root cause of the problem, but it clearly is a CPython issue not a Cython one.
Thanks.

@da-woods
Copy link
Contributor

Hi both: I've created #125868 with a bit of extra debugging detail (I stopped trying to debug at the point that reality and pdb started contradicting each other)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants