-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-122712: Test CALL_ALLOC_AND_ENTER_INIT
handles reassignment of __code__
#122713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Failing hypothesis tests are a known issue: #122686 |
JIT test failures look like unrelated issues with qemu:
|
@brandtbucher @markshannon - I've updated this to perform the necessary checks inline in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the correct fix. Thanks.
I'd like the DEOPT test streamlined a bit, but it looks good otherwise.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @markshannon's suggestion. Otherwise, looks good!
Looks like this was fixed on main by gh-123140. The underlying issue is still present in 3.13, however. @markshannon how would you like to proceed with fixing on 3.13? |
GH-123184 is a backport of this pull request to the 3.13 branch. |
Closing this since gh-123140 fixes it on main. |
Sorry. I meant to merge this first, so we got the test before changing Do you want to re-open this PR with just the test, or make a new one? |
|
|
Also, the failure is relative to the 3.13 backport: gh-123184. |
That failure seems like it should be unrelated to this change. I also haven't been able to reproduce it locally. |
__code__
reassignment in CALL_ALLOC_AND_ENTER_INIT
CALL_ALLOC_AND_ENTER_INIT
handles reassignment of __code__
@markshannon - No worries. Reopened this with just the test. |
Thanks |
Add a test to verify
CALL_ALLOC_AND_ENTER_INIT
handles the case where the__init__
function's code object is reassigned.__init__
method is reassigned #122712