Skip to content

gh-123089: avoid _IterationGuard for WeakSet, make it thread safe #123279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 24, 2024

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but I think this deserves a NEWS entry.

@kumaraditya303
Copy link
Contributor Author

The change looks good to me, but I think this deserves a NEWS entry.

Added news entry, thanks for your review!

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) August 27, 2024 12:46
@kumaraditya303 kumaraditya303 merged commit 03f5abf into python:main Aug 27, 2024
34 checks passed
@picnixz
Copy link
Member

picnixz commented Aug 27, 2024

Does it need to be backported to 3.13? (or at least to have a PR pending for it)?

@kumaraditya303
Copy link
Contributor Author

No, this change is for Python 3.14+

@kumaraditya303 kumaraditya303 deleted the thread-safe-weakset branch August 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants