gh-86673: Harden test_ttk.test_element_create_image
#123335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Aug 26, 2024
•
erlend-aasland
commented
- Issue: test_ttk_guionly test failures on macOS with Tcl/Tk 8.6.10 #86673
erlend-aasland
added
skip news
needs backport to 3.12
|
This is simply @ronaldoussoren's patch from the issue. Adding Serhiy as a reviewer, because of his Tk competence. |
|
We should perhaps add an explanatory comment before eventually landing this. |
erlend-aasland
changed the title
erlend-aasland
changed the title
test_ttk.test_element_create_image
serhiy-storchaka
approved these changes
Sep 26, 2024
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2024
…-123335) (cherry picked from commit 08e1bbe) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-124654 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2024
…-123335) (cherry picked from commit 08e1bbe) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
|
Thanks, Serhiy and Ronald! |
|
GH-124655 is a backport of this pull request to the 3.12 branch. |
erlend-aasland
pushed a commit
that referenced
this pull request
Sep 27, 2024
Yhg1s
pushed a commit
that referenced
this pull request
Sep 27, 2024
…) (#124654) gh-86673: Harden `test_ttk.test_element_create_image` (GH-123335) (cherry picked from commit 08e1bbe) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.