Skip to content

gh-101860: document property.__name__ #123399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Aug 27, 2024

I think I need to change 3.13 What's New since this change was introduced in 3.13. Not sure if Sphinx will complain with how I documented. (waiting for the docs to build to see how it renders)

cc @eltoder @JelleZijlstra


📚 Documentation preview 📚: https://cpython-previews--123399.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 27, 2024
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Other language changes" doesn't feel like a great location for the news entry, but other changes to builtins are documented there too, so it's the right choice for now.

Thanks!

@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Aug 27, 2024
@encukou encukou merged commit 40fff90 into python:main Aug 28, 2024
30 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2024
(cherry picked from commit 40fff90)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 28, 2024

GH-123428 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 28, 2024
@picnixz picnixz deleted the docs/whats-new-3.13-name-property-101860 branch August 28, 2024 14:20
JelleZijlstra pushed a commit that referenced this pull request Aug 29, 2024
(cherry picked from commit 40fff90)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants