gh-123430: Add dark mode support to pages generated by http.server #123475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error pages and the directory lists generated by http.server did not allow browsers to enable the inbuilt dark mode. This change allows for that by setting the css property color-scheme properly.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst
Outdated
Show resolved
Hide resolved
…7wXl9.rst Co-authored-by: Peter Bierma <[email protected]>
hugovk
approved these changes
Aug 30, 2024
vstinner
approved these changes
Sep 3, 2024
Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst
Outdated
Show resolved
Hide resolved
|
Should this get backported? The user seeing the incorrect color scheme sounds like a bug to me. |
It's a new feature, it should not be backported. |
|
@YorikHansen Please could you also mention this in What's New? https://docs.python.org/3.14/whatsnew/3.14.html#improved-modules |
|
Thank you! |
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error pages and the directory lists generated by http.server did not allow browsers to enable the inbuilt dark mode. This change allows for that by setting the css property color-scheme properly.
:root { color-scheme: light dark; }to http.server directory list and error pages #123430