Skip to content

gh-123579: Document exclamation token #123612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2024
Merged

gh-123579: Document exclamation token #123612

merged 2 commits into from
Sep 3, 2024

Conversation

Glyphack
Copy link
Contributor

@Glyphack Glyphack commented Sep 2, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 2, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Sep 2, 2024
@Glyphack Glyphack marked this pull request as ready for review September 2, 2024 18:01
@Glyphack Glyphack force-pushed the document-exclamation-token branch from d3891ca to c7372e6 Compare September 2, 2024 19:39
@lysnikolaou
Copy link
Member

Hmm, now that I look at this again, I'm not sure whether ! qualifies as an operator. It might be better off being in the delimeters list? @pablogsal What do you think?

@pablogsal
Copy link
Member

Hmm, now that I look at this again, I'm not sure whether ! qualifies as an operator. It might be better off being in the delimeters list? @pablogsal What do you think?

It's certainly not an operator. I would include in the delimiter list for sure. It's very similar to the ":" in the sense that it separates two parts, it doesn't apply to any or both of them

lysnikolaou
lysnikolaou approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou lysnikolaou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 3, 2024
@lysnikolaou lysnikolaou merged commit 68fe575 into python:main Sep 3, 2024
27 checks passed
@miss-islington-app
Copy link

Thanks @Glyphack for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2024
@Glyphack @miss-islington
pythongh-123579: Document exclamation token (pythonGH-123612)
8c2f667 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 3, 2024

GH-123637 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2024
@Glyphack @miss-islington
pythongh-123579: Document exclamation token (pythonGH-123612)
765ca87 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 3, 2024

GH-123638 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 3, 2024
@Glyphack Glyphack deleted the document-exclamation-token branch September 3, 2024 14:50
lysnikolaou pushed a commit that referenced this pull request Sep 3, 2024
@miss-islington @Glyphack
[3.12] gh-123579: Document exclamation token (GH-123612) (#123638)
acb19be 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <[email protected]>
lysnikolaou pushed a commit that referenced this pull request Sep 3, 2024
@miss-islington @Glyphack
[3.13] gh-123579: Document exclamation token (GH-123612) (#123637)
95ebca1 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Glyphack @lysnikolaou @pablogsal