Skip to content

gh-123915: Ensure that AMD64 and ARM64 builds use different directories #123918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2024
Merged

gh-123915: Ensure that AMD64 and ARM64 builds use different directories #123918

merged 2 commits into from
Sep 10, 2024

Conversation

adang1345
Copy link
Contributor

@adang1345 adang1345 commented Sep 10, 2024 •
edited by bedevere-app bot
Loading

This fixes #123915 and ensures that when buildrelease.bat is used, AMD64 and ARM64 builds happen in different directories.

@adang1345 adang1345 requested a review from a team as a code owner September 10, 2024 19:10
@adang1345 adang1345 changed the title Ensure that AMD64 and ARM64 builds use different directories gh-123915: Ensure that AMD64 and ARM64 builds use different directories Sep 10, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 10, 2024
Closed
@zooba zooba added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 10, 2024
@zooba zooba enabled auto-merge (squash) September 10, 2024 19:29
@zooba zooba merged commit 00ffdf2 into python:main Sep 10, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @adang1345 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2024
@adang1345 @miss-islington
pythongh-123915: Ensure that Windows AMD64 and ARM64 release builds u…
bccf62e 
…se different directories (pythonGH-123918)

(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2024

GH-123921 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2024
@adang1345 @miss-islington
pythongh-123915: Ensure that Windows AMD64 and ARM64 release builds u…
69d43b5 
…se different directories (pythonGH-123918)

(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 10, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2024

GH-123922 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 10, 2024
zooba pushed a commit that referenced this pull request Sep 10, 2024
@miss-islington @adang1345
gh-123915: Ensure that Windows AMD64 and ARM64 release builds use dif…
41608f1 
…ferent directories (GH-123918)

(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @adang1345
[3.13] gh-123915: Ensure that Windows AMD64 and ARM64 release builds …
3fd3b8a 
…use different directories (GH-123918) (#123921)

gh-123915: Ensure that Windows AMD64 and ARM64 release builds use different directories (GH-123918)
(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
@alciobi
Copy link

alciobi commented Jan 28, 2025

شكرا لكم جميعا ✋🏻 💞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buildrelease.bat uses same build directory for AMD64 and ARM64
3 participants
@adang1345 @alciobi @zooba