Skip to content

Adjust build_ubuntu_ssltests job to use cache for the correct OS version #124403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

zware
Copy link
Member

@zware zware commented Sep 24, 2024

This is a forward-port of the fix in GH-123699 to ensure that the cached OpenSSL builds are tagged with the OS version.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zware zware merged commit 54dd77f into python:main Sep 25, 2024
43 checks passed
@zware zware deleted the ubuntu_ci_cache_fixup branch September 25, 2024 01:27
@miss-islington-app
Copy link

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 25, 2024

GH-124481 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
@miss-islington-app
Copy link

Sorry, @zware, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 54dd77fb8c880d7655fffab934978e277b4275fe 3.11

@bedevere-app
Copy link

bedevere-app bot commented Sep 25, 2024

GH-124482 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 25, 2024
zware added a commit to zware/cpython that referenced this pull request Sep 25, 2024
…OS version (pythonGH-124403)

(cherry picked from commit 54dd77f)

Co-authored-by: Zachary Ware <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 26, 2024
…OS version (GH-124403) (#124481)

Adjust build_ubuntu_ssltests job to use cache for the correct OS version (GH-124403)
(cherry picked from commit 54dd77f)

Co-authored-by: Zachary Ware <[email protected]>
@zware zware removed the needs backport to 3.11 only security fixes label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants