Skip to content

gh-124612: Good bye dockerfile and use GHCR package #124626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Sep 26, 2024

@corona10
Copy link
Member Author

Host information
----------------
OS: Ubuntu 22.04.5 LTS (stable release)
Image details: https://github.com/github/codespaces-host-images/blob/main/README.md
----------------
Configuration starting...
Cloning...
Creating container...
$ devcontainer up --id-label Type=codespaces --workspace-folder /var/lib/docker/codespacemount/workspace/cpython --mount type=bind,source=/.codespaces/agent/mount/cache,target=/vscode --user-data-folder /var/lib/docker/codespacemount/.persistedshare --container-data-folder .vscode-remote/data/Machine --container-system-data-folder /var/vscode-remote --log-level trace --log-format json --update-remote-user-uid-default never --mount-workspace-git-root false --omit-config-remote-env-from-metadata --skip-non-blocking-commands --skip-post-create --config "/var/lib/docker/codespacemount/workspace/cpython/.devcontainer/devcontainer.json" --override-config /root/.codespaces/shared/merged_devcontainer.json --default-user-env-probe loginInteractiveShell --container-session-data-folder /workspaces/.codespaces/.persistedshare/devcontainers-cli/cache --secrets-file /root/.codespaces/shared/user-secrets-envs.json
[213 ms] @devcontainers/cli 0.68.0. Node.js v18.20.4. linux 6.8.0-1014-azure x64.
[2432 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,src=/var/lib/docker/codespacemount/workspace,dst=/workspaces --mount source=/root/.codespaces/shared,target=/workspaces/.codespaces/shared,type=bind --mount source=/var/lib/docker/codespacemount/.persistedshare,target=/workspaces/.codespaces/.persistedshare,type=bind --mount source=/.codespaces/agent/mount,target=/.codespaces/bin,type=bind --mount source=/mnt/containerTmp,target=/tmp,type=bind --mount type=bind,src=/.codespaces/agent/mount/cache,dst=/vscode -l Type=codespaces -e CODESPACES=******** -e ContainerVersion=13 -e RepositoryName=cpython --label ContainerVersion=13 --hostname codespaces-543579 --add-host codespaces-543579:127.0.0.1 --cap-add sys_nice --network host --entrypoint /bin/sh -l devcontainer.metadata=[{"onCreateCommand":["dnf","install","-y","which","zsh","fish","/usr/bin/setfacl"],"updateContentCommand":{"python":"./configure --config-cache --with-pydebug && make -s -j `nproc`","docs":["make","--directory","Doc","venv","html"]},"postCreateCommand":{"umask fix: workspace":["sudo","setfacl","-bnR","."],"umask fix: /tmp":["sudo","setfacl","-bnR","/tmp"]},"customizations":{"vscode":{"extensions":["brettcannon.zephyr-asdl","maelvalais.autoconf","ms-vscode.cpptools","ms-vscode.live-server","ms-python.python"],"settings":{"C_Cpp.default.compilerPath":"/usr/bin/clang","C_Cpp.default.cStandard":"c11","C_Cpp.default.defines":["CONFIG_64","Py_BUILD_CORE"],"C_Cpp.default.includePath":["${workspaceFolder}/*","${workspaceFolder}/Include/**"],"C_Cpp.errorSquiggles":"disabled","editor.insertSpaces":********,"editor.rulers":[80],"editor.tabSize":4,"editor.trimAutoWhitespace":********,"files.associations":{"*.h":"c"},"files.encoding":"utf8","files.eol":"\n","files.insertFinalNewline":********,"files.trimTrailingWhitespace":********,"python.analysis.diagnosticSeverityOverrides":{"reportShadowedImports":"none","reportMissingImports":"none"},"python.analysis.extraPaths":["Lib"],"python.defaultInterpreterPath":"./python","[restructuredtext]":{"editor.tabSize":3}}}},"mounts":["source=/root/.codespaces/shared,target=/workspaces/.codespaces/shared,type=bind","source=/var/lib/docker/codespacemount/.persistedshare,target=/workspaces/.codespaces/.persistedshare,type=bind","source=/.codespaces/agent/mount,target=/.codespaces/bin,type=bind","source=/mnt/containerTmp,target=/tmp,type=bind"],"containerEnv":{"CODESPACES":"********","ContainerVersion":"13","RepositoryName":"cpython"}}] ghcr.io/python/devcontainer:2024.09.25.11038928730 -c echo Container started
Unable to find image 'ghcr.io/python/devcontainer:2024.09.25.11038928730' locally
2024.09.25.11038928730: Pulling from python/devcontainer
f7bb57d05c2a: Pull complete 
7c85761a6837: Pull complete 
685abbd8f263: Pull complete 
ce233963f73c: Pull complete 
Digest: sha256:900073c868afb164a1b8ab2bec1a8e3443f92b143793049d8e01697540a533b4
Status: Downloaded newer image for ghcr.io/python/devcontainer:2024.09.25.11038928730
Container started
Outcome: success User: root WorkspaceFolder: /workspaces/cpython
devcontainer process exited with exit code 0
...

@corona10 corona10 marked this pull request as ready for review September 26, 2024 19:12
@corona10 corona10 merged commit a4d1fdf into python:main Sep 26, 2024
36 checks passed
@corona10 corona10 deleted the gh-124612-dev-container branch September 27, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants