Skip to content

bpo-36407: Fix writing indentations of CDATA section (xml.dom.minidom) #12514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2019
Merged

bpo-36407: Fix writing indentations of CDATA section (xml.dom.minidom) #12514

merged 4 commits into from
Mar 27, 2019

Conversation

vsurjaninov
Copy link
Contributor

@vsurjaninov vsurjaninov commented Mar 23, 2019 •
edited by bedevere-bot
Loading

bpo-36407: This little change fixes indentations when we are writing xml with CDATA section. Also a result document now can be parsed correctly as if we would write it without indentations.

https://bugs.python.org/issue36407

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

scoder
scoder reviewed Mar 23, 2019
View reviewed changes
Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me, thanks!

@scoder
Copy link
Contributor

scoder commented Mar 23, 2019

Test also looks good now. CLA pending.

eamanu
eamanu reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please sign cla

@serhiy-storchaka serhiy-storchaka merged commit 384b81d into python:master Mar 27, 2019
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels Mar 27, 2019
@miss-islington
Copy link
Contributor

Thanks @vsurjaninov for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @vsurjaninov for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vsurjaninov and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 384b81d923addd52125e94470b11d2574ca266a9 3.7

@bedevere-bot
Copy link

GH-12578 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2019
@vsurjaninov @miss-islington
bpo-36407: Fix writing indentations of CDATA section (xml.dom.minidom…
2e5ec15 
…). (pythonGH-12514)

(cherry picked from commit 384b81d)

Co-authored-by: Vladimir Surjaninov <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Mar 27, 2019
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoder scoder scoder left review comments

@eamanu eamanu eamanu left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsurjaninov @the-knights-who-say-ni @scoder @miss-islington @bedevere-bot @serhiy-storchaka @eamanu