-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-124969: Make locale.nl_langinfo(locale.ALT_DIGITS) returning a string again #125774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-124969: Make locale.nl_langinfo(locale.ALT_DIGITS) returning a string again #125774
Conversation
… a string again This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms.
@kulikjak, could you please test that the modified test is passed on Solaris? |
Hi @serhiy-storchaka, thanks! I tested the patch, and
There is currently no locale in
(and adjusted those two in |
Is not ar_AE equivalent to ar_AE.UTF-8? |
Unfortunately not. Mostly due to historical reasons, default locales on Solaris are not UTF-8. And I guess that for similar reasons, only the UTF-8 variants of these two include |
Uh, so with this second change I found that 'ja_JP.PCK' on Solaris returns 101 symbols. At least those three tested match, which is nice. The standard allows max 100, but considering that the last value is a new symbol (and not just a concatenation of those before), I can see why it is there. That said, I propose removing 'ja_JP.PCK' from tested locales (I don't think PCK is available on other platforms anyway). |
Thank you for your help @kulikjak. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
… a string again (pythonGH-125774) This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms. (cherry picked from commit dcc4fb2) Co-authored-by: Serhiy Storchaka <[email protected]>
… a string again (pythonGH-125774) This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms. (cherry picked from commit dcc4fb2) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-125804 is a backport of this pull request to the 3.13 branch. |
GH-125805 is a backport of this pull request to the 3.12 branch. |
…g a string again (GH-125774) (GH-125805) This is a follow up of GH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms. (cherry picked from commit dcc4fb2) Co-authored-by: Serhiy Storchaka <[email protected]>
…g a string again (GH-125774) (GH-125804) This is a follow up of GH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms. (cherry picked from commit dcc4fb2) Co-authored-by: Serhiy Storchaka <[email protected]>
… a string again (pythonGH-125774) This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms.
This is a follow up of GH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms.
📚 Documentation preview 📚: https://cpython-previews--125774.org.readthedocs.build/