Skip to content

[3.12] gh-125783: Add tests to prevent regressions with the combination of ctypes and metaclasses. (GH-125881) #125988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 25, 2024

…n of `ctypes` and metaclasses. (pythonGH-125881)

(cherry picked from commit 1384409)

Co-authored-by: Jun Komoda <[email protected]>
@junkmd
Copy link
Contributor

junkmd commented Oct 26, 2024

Unlike main and 3.13, 3.12 does not yet include the test_ctypes._support module, which is causing test failures.

I think a maintainer with the appropriate permissions needs to do such as git checkout 1384409 -- Lib/test/test_ctypes/_support.py on this branch.

@encukou
Copy link
Member

encukou commented Oct 28, 2024

I'll try backporting all of #113727.

This partially backports be89ee5
(python#113727)

Co-authored-by: Erlend E. Aasland <[email protected]>
@encukou
Copy link
Member

encukou commented Oct 28, 2024

Nope, too invasive. I'll add _support.py as suggested. If we backport the whole commit later, _support.py shouldn't conflict with it.

@encukou encukou merged commit bce9df9 into python:3.12 Oct 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir topic-ctypes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants