-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-126353: remove implicit creation of loop from get_event_loop
#126354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
496eee6
remove implicit creation of loops
kumaraditya303 3c9075d
📜🤖 Added by blurb_it.
blurb-it[bot] 9f79f73
fix cmdline
kumaraditya303 102475a
Merge branch 'get-event-loop' of https://github.com/kumaraditya303/cp…
kumaraditya303 516f097
fix tests
kumaraditya303 1214f07
code review
kumaraditya303 b84ded1
fixup
kumaraditya303 29caae3
improve news
kumaraditya303 f6c1588
final fixup
kumaraditya303 04d9667
Apply suggestions from code review
kumaraditya303 6687913
add back get_running_loop
kumaraditya303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -924,7 +924,7 @@ def test_python_gil(self): | |
self.assertEqual(proc.stderr, '') | ||
|
||
def test_python_asyncio_debug(self): | ||
code = "import asyncio; print(asyncio.get_event_loop().get_debug())" | ||
code = "import asyncio; print(asyncio.new_event_loop().get_debug())" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this needs a |
||
rc, out, err = assert_python_ok('-c', code, PYTHONASYNCIODEBUG='1') | ||
self.assertIn(b'True', out) | ||
|
||
|
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2024-11-03-10-48-07.gh-issue-126353.ChDzot.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
:func:`asyncio.get_event_loop` now does not implicitly creates an event loop. | ||
It now raises a :exc:`RuntimeError` if there is no set event loop. Patch by Kumar Aditya. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please mention what should be used instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_event_loop()
. But these who need a new even loop already know this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_event_loop is not correct, it should be asyncio.run or asyncio.Runner
Worst case it would be asyncio.EventLoop, new_event_loop uses the policy system