GH-120423: pathname2url(): handle forward slashes in Windows paths
#126593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paths Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes.
barneygale
added
topic-pathlib
needs backport to 3.12
nineteendo
reviewed
Nov 8, 2024
ruidazeng
approved these changes
Nov 11, 2024
ByteJoseph
approved these changes
Nov 11, 2024
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
barneygale
added
needs backport to 3.12
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
ambv
added
needs backport to 3.12
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2024
…paths (pythonGH-126593) Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes. (cherry picked from commit bf224bd) Co-authored-by: Barney Gale <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2024
…paths (pythonGH-126593) Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes. (cherry picked from commit bf224bd) Co-authored-by: Barney Gale <[email protected]>
|
GH-126763 is a backport of this pull request to the 3.12 branch. |
|
GH-126764 is a backport of this pull request to the 3.13 branch. |
barneygale
added a commit
that referenced
this pull request
Nov 12, 2024
… paths (GH-126593) (#126763) GH-120423: `pathname2url()`: handle forward slashes in Windows paths (GH-126593) Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes. (cherry picked from commit bf224bd) Co-authored-by: Barney Gale <[email protected]>
barneygale
added a commit
that referenced
this pull request
Nov 12, 2024
… paths (GH-126593) (#126764) GH-120423: `pathname2url()`: handle forward slashes in Windows paths (GH-126593) Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes. (cherry picked from commit bf224bd) Co-authored-by: Barney Gale <[email protected]>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…paths (python#126593) Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…paths (python#126593) Adjust `urllib.request.pathname2url()` so that forward slashes in Windows paths are handled identically to backward slashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
urllib.request.pathname2url()so that forward slashes in Windows paths are handled identically to backward slashes. This fixes an issue wherepathname2url()would not properly recognise some UNC paths that use forward slashesnturl2path.pathname2url()doesn't handle forward slashes #120423