Skip to content

Docs: Miscellaneous corrections to simple statements in the language reference #126720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

bombs-kim
Copy link
Contributor

@bombs-kim bombs-kim commented Nov 12, 2024


📚 Documentation preview 📚: https://cpython-previews--126720.org.readthedocs.build/

@@ -533,8 +533,8 @@ The :keyword:`!yield` statement
yield_stmt: `yield_expression`

A :keyword:`yield` statement is semantically equivalent to a :ref:`yield
expression <yieldexpr>`. The yield statement can be used to omit the parentheses
that would otherwise be required in the equivalent yield expression
expression <yieldexpr>`. The :keyword:`yield` statement can be used to omit the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have been intentional here to not use markup: we don’t want a paragraph littered with the same link. So double backticks could be enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a link to the Devguide @bombs-kim https://devguide.python.org/documentation/style-guide/#links

As @merwok mentions there is no need to have multiple links in the same paragraph, double backticks would be preferred.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to rereview after the changes are made. Thanks.

@bombs-kim
Copy link
Contributor Author

@merwok @willingc
Thanks you for the correction and the guidance! I've replaced repeated links with double backticks.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates @bombs-kim.

@willingc willingc added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 15, 2024
@willingc willingc merged commit 94a7a4e into python:main Nov 15, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @bombs-kim for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @bombs-kim and @willingc, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 94a7a4e22fb8f567090514785c69e65298acca42 3.13

@miss-islington-app
Copy link

Sorry, @bombs-kim and @willingc, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 94a7a4e22fb8f567090514785c69e65298acca42 3.12

willingc pushed a commit to willingc/cpython that referenced this pull request Nov 15, 2024
…reference (pythonGH-126720)

* Replace: The :keyword:`global` -> The :keyword:`global` statement
Add :keyword: when it's needed

* Replace repeated links with duoble backticks

(cherry picked from commit 94a7a4e)
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2024

GH-126885 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 15, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2024

GH-126885 is a backport of this pull request to the 3.13 branch.

1 similar comment
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2024

GH-126885 is a backport of this pull request to the 3.13 branch.

willingc pushed a commit to willingc/cpython that referenced this pull request Nov 15, 2024
…nguage reference (pythonGH-126720)

* Replace: The :keyword:`global` -> The :keyword:`global` statement
Add :keyword: when it's needed

* Replace repeated links with duoble backticks
(cherry picked from commit 94a7a4e)

Co-authored-by: Beomsoo Kim <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2024

GH-126891 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 15, 2024
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
…nguage reference (GH-126720) (#126891)

* Replace: The :keyword:`global` -> The :keyword:`global` statement
Add :keyword: when it's needed

* Replace repeated links with duoble backticks
(cherry picked from commit 94a7a4e)

Co-authored-by: Beomsoo Kim <[email protected]>
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
…s in the language reference (GH-126720) (#126885)

Docs: Miscellaneous corrections to simple statements in the language reference (GH-126720)

* Replace: The :keyword:`global` -> The :keyword:`global` statement
Add :keyword: when it's needed

* Replace repeated links with duoble backticks

(cherry picked from commit 94a7a4e)

Co-authored-by: Beomsoo Kim <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
…reference (pythonGH-126720)

* Replace: The :keyword:`global` -> The :keyword:`global` statement
Add :keyword: when it's needed

* Replace repeated links with duoble backticks
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…reference (pythonGH-126720)

* Replace: The :keyword:`global` -> The :keyword:`global` statement
Add :keyword: when it's needed

* Replace repeated links with duoble backticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants