Skip to content

gh-126405: fix use-after-free in _asyncio.Future.remove_done_callback #126733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

gh-126405: fix use-after-free in _asyncio.Future.remove_done_callback #126733

merged 1 commit into from
Nov 12, 2024

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 12, 2024 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Closed
asvetlov
asvetlov approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kumaraditya303 kumaraditya303 merged commit 37c57df into python:main Nov 12, 2024
51 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the uaf branch November 12, 2024 12:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2024
@kumaraditya303 @miss-islington
pythongh-126405: fix use-after-free in `_asyncio.Future.remove_done_c…
c70d59c 
…allback` (pythonGH-126733)

(cherry picked from commit 37c57df)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

GH-126736 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 12, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2024
@kumaraditya303 @miss-islington
pythongh-126405: fix use-after-free in `_asyncio.Future.remove_done_c…
ada6b86 
…allback` (pythonGH-126733)

(cherry picked from commit 37c57df)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

GH-126737 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 12, 2024
kumaraditya303 added a commit that referenced this pull request Nov 12, 2024
@miss-islington @kumaraditya303
[3.12] gh-126405: fix use-after-free in `_asyncio.Future.remove_done_…
b13b84a 
…callback` (GH-126733) (#126737)

gh-126405: fix use-after-free in `_asyncio.Future.remove_done_callback` (GH-126733)
(cherry picked from commit 37c57df)

Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303 added a commit that referenced this pull request Nov 12, 2024
@miss-islington @kumaraditya303
[3.13] gh-126405: fix use-after-free in `_asyncio.Future.remove_done_…
2da063e 
…callback` (GH-126733) (#126736)

gh-126405: fix use-after-free in `_asyncio.Future.remove_done_callback` (GH-126733)
(cherry picked from commit 37c57df)

Co-authored-by: Kumar Aditya <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@kumaraditya303 @picnixz
pythongh-126405: fix use-after-free in `_asyncio.Future.remove_done_c…
1a27ac6 
…allback` (python#126733)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@kumaraditya303 @ebonnal
pythongh-126405: fix use-after-free in `_asyncio.Future.remove_done_c…
e9ca8b4 
…allback` (python#126733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UAF in asyncio.Future when removing a callback while fut->fut_callbacks length is 1
2 participants
@kumaraditya303 @asvetlov