-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-126899: Add **kw
to tkinter.Misc.after
and tkinter.Misc.after_idle
#126900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For this to work you need to make func and ms positional only, which is backwards incompatible |
Is making I've found something similar elsewhere in Line 444 in 2313f84
and Line 547 in 2313f84
|
It is not necessary to make other parameters positional only, but this can be considered in future, together with other methods that have var-keyword parameter. In general, I do not see objections against this change. It does not also look that other Tkinter methods need similar change. But please add tests and a What's New entry. |
@serhiy-storchaka PTAL, thanks! |
Misc/NEWS.d/next/Library/2024-11-16-10-52-48.gh-issue-126899.GFnfBt.rst
Outdated
Show resolved
Hide resolved
…FnfBt.rst Co-authored-by: Serhiy Storchaka <[email protected]>
@terryjreedy , As mentioned above, I guess you may be able to help us review this PR, it's easy, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave code changes to Serhiy.
Misc/NEWS.d/next/Library/2024-11-16-10-52-48.gh-issue-126899.GFnfBt.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM.
I have made the requested changes; please review again. |
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
I don't know why the test failed. Compared to the last commit, I only modified the parts that belonged to the documentation. |
There was a (rare) timeout error in building Python for the test. Nothing to do with us. Re-running the failed test only. |
….after_idle` (python#126900) --------- Co-authored-by: Serhiy Storchaka <[email protected]>
….after_idle` (python#126900) --------- Co-authored-by: Serhiy Storchaka <[email protected]>
….after_idle` (python#126900) --------- Co-authored-by: Serhiy Storchaka <[email protected]>
**kw
totkinter.Misc.after
andtkinter.Misc.after_idle
#126899