Skip to content

gh-126947: Typechecking for _pydatetime.timedelta.__new__ arguments #126949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2024
Merged

gh-126947: Typechecking for _pydatetime.timedelta.__new__ arguments #126949

merged 5 commits into from
Nov 19, 2024

Conversation

bombs-kim
Copy link
Contributor

@bombs-kim bombs-kim commented Nov 18, 2024 •
edited by bedevere-app bot
Loading

  • Add typecheck in _pydatetime.timedelta so that same format error is raised as in _datetime.timedelta
  • Add relevant tests for the new typecheck in datetime module

@bedevere-app bedevere-app bot mentioned this pull request Nov 18, 2024
Closed
sobolevn
sobolevn reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now python implementation is in line with C implementation. Please, add a NEWS entry.

@bombs-kim
Copy link
Contributor Author

@sobolevn a NEWS entry has been added

@sobolevn
Copy link
Member

Thanks! Let's wait for code-owners to review :)

vstinner
vstinner approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The PR doesn't change the exception type, but provides a better error message.

ZeroIntensity
ZeroIntensity approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might as well hop on the approval train :)

How do we feel about backporting?

@vstinner
Copy link
Member

How do we feel about backporting?

It's a bad idea to change error messages in a stable release, it can break tests.

@sobolevn sobolevn merged commit 8da9920 into python:main Nov 19, 2024
40 checks passed
@sobolevn
Copy link
Member

Thanks everyone!

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@bombs-kim @sobolevn
@ZeroIntensity @ebonnal
pythongh-126947: Typechecking for _pydatetime.timedelta.__new__ argum…
9380402 
…ents (python#126949)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@vstinner vstinner vstinner approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bombs-kim @sobolevn @vstinner @ZeroIntensity @Eclips4