gh-126986: Drop _PyInterpreterState_FailIfNotRunning() #126988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Nov 18, 2024
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2024
…h-126988) We replace it with _PyErr_SetInterpreterAlreadyRunning(). (cherry picked from commit d6b3e78) Co-authored-by: Eric Snow <[email protected]>
|
GH-126995 is a backport of this pull request to the 3.13 branch. |
|
While this is a private API change, it's still technically breaking the ABI because of the |
|
It's okay. I'll sort out the ABI change. It's all internal ABI so we're safe to do it. |
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
Nov 21, 2024
…h-126988) We replace it with _PyErr_SetInterpreterAlreadyRunning().
ericsnowcurrently
added a commit
that referenced
this pull request
Nov 21, 2024
…h-127112) This is a pseudo-backport of d6b3e78 (gh-126988). In that change for 3.14+, we dropped _PyInterpreterState_FailIfNotRunning() and added _PyErr_SetInterpreterAlreadyRunning(). Here, we replace usage of _PyInterpreterState_FailIfNotRunning() with the inlined equivalent of _PyErr_SetInterpreterAlreadyRunning(), without adding that function. That way we avoid changing the 3.13 ABI.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…h-126988) We replace it with _PyErr_SetInterpreterAlreadyRunning().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We replace it with
_PyErr_SetInterpreterAlreadyRunning().