Skip to content

gh-127522: wsgiref: indicate that start_response objects should follow a specific protocol #127525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Dec 2, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 2, 2024
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes docs Documentation in the Doc dir awaiting review skip news and removed docs Documentation in the Doc dir awaiting review skip news labels Dec 2, 2024
The `StartResponse` class is documented under `wsgiref.types.StartResponse` and not `wsgiref.StartResponse`.
@picnixz picnixz requested a review from hugovk December 2, 2024 18:40
@picnixz picnixz requested a review from encukou January 11, 2025 10:15
@picnixz
Copy link
Member Author

picnixz commented Feb 15, 2025

@encukou friendly ping in case this passed under your radar

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did, thanks for the ping!

+1, but there's a Sphinx warning to fix

@picnixz picnixz requested a review from encukou February 22, 2025 10:49
@encukou encukou merged commit 39ba4b6 into python:main Feb 24, 2025
24 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2025
…ld follow a specific protocol (pythonGH-127525)

(cherry picked from commit 39ba4b6)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 24, 2025

GH-130504 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 24, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2025
…ld follow a specific protocol (pythonGH-127525)

(cherry picked from commit 39ba4b6)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 24, 2025

GH-130505 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 24, 2025
@picnixz picnixz deleted the doc/wsgiref/start-response-127522 branch February 24, 2025 12:57
encukou pushed a commit that referenced this pull request Feb 24, 2025
…uld follow a specific protocol (GH-127525) (GH-130504)

(cherry picked from commit 39ba4b6)

Co-authored-by: Bénédikt Tran <[email protected]>
encukou pushed a commit that referenced this pull request Feb 24, 2025
…uld follow a specific protocol (GH-127525) (GH-130505)

(cherry picked from commit 39ba4b6)

Co-authored-by: Bénédikt Tran <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants