Skip to content

gh-127518: Fix pystats build after #127169 #127526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Dec 2, 2024

The pystats build broke in #127169 due to the reorganization of _Py_Specialize_StoreSubscr. This seems to do the right thing.

@mdboom mdboom requested a review from colesbury December 2, 2024 18:27
@colesbury colesbury changed the title gh-127518: Fix pystats build after #127619 gh-127518: Fix pystats build after #127169 Dec 2, 2024
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops... thanks for fixing this!

@mdboom mdboom enabled auto-merge (squash) December 2, 2024 18:33
@colesbury
Copy link
Contributor

macOS free threading CI failure should be fixed by #127524

@mdboom
Copy link
Contributor Author

mdboom commented Dec 2, 2024

Ooops... thanks for fixing this!

No problem. We don't have CI for it...

@colesbury
Copy link
Contributor

#127524 has been merged so I merged "main" into this PR in order to fix the CI issue.

@mdboom mdboom merged commit edefb86 into python:main Dec 2, 2024
39 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants