Skip to content

CI: Use bash to properly expand variable #127822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

CI: Use bash to properly expand variable #127822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/reusable-windows-msi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ jobs:
with:
persist-credentials: false
- name: Build CPython installer
run: .\Tools\msi\build.bat --doc -"${ARCH}"
run: ./Tools/msi/build.bat --doc -"${ARCH}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that with shell: bash both / and \\ work for paths, but not \.
I've seen (and used) \\ elsewhere, but since this is the only instance in this file and / is more readable we don't need to worry about consistency here.

Copy link
Member

@AlexWaygood AlexWaygood Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, / and \\ are both valid path separators on Windows, so using / always works fine for paths on Windows. The difference between the platforms is that / is not the default path separator on Windows.

shell: bash
Loading