Skip to content

GH-128131: Completely support random read access of uncompressed unencrypted files in ZipFile #128143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 20, 2025
Merged

GH-128131: Completely support random read access of uncompressed unencrypted files in ZipFile #128143

merged 13 commits into from
Jan 20, 2025

Conversation

5ec1cff
Copy link
Contributor

@5ec1cff 5ec1cff commented Dec 21, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app
Copy link

bedevere-app bot commented Dec 21, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Dec 21, 2024
Closed
@picnixz
Copy link
Member

picnixz commented Dec 21, 2024 •
edited
Loading

Closing as a duplicate of #128132. Please do not copy PRs made by others. Thanks.

EDIT: It appears that this is either the same person or two people collaborating with each other. Anyway, please do not update two identical PRs. Thanks

@picnixz picnixz closed this Dec 21, 2024
@5ec1cff 5ec1cff deleted the 5ec1cff-patch-1 branch December 21, 2024 01:59
@5ec1cff 5ec1cff restored the 5ec1cff-patch-1 branch December 21, 2024 03:19
@5ec1cff
Copy link
Contributor Author

5ec1cff commented Dec 21, 2024 •
edited
Loading

Closing as a duplicate of #128132. Please do not copy PRs made by others. Thanks.

EDIT: It appears that this is either the same person or two people collaborating with each other. Anyway, please do not update two identical PRs. Thanks

We discussed about this issue and decide that I submit the pr. vvb2060 has already closed his pr. Please reopen my pr, sorry for inconvenience.

@picnixz picnixz reopened this Dec 21, 2024
picnixz
picnixz reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests for that please?

@5ec1cff 5ec1cff changed the title GH-128131: Support forward seek in uncompressed unencrypted ZipExtFile GH-128131: Support fast forward seek in uncompressed unencrypted ZipExtFile Dec 21, 2024
@5ec1cff
Copy link
Contributor Author

5ec1cff commented Dec 21, 2024

Can we have tests for that please?

Added.

picnixz
picnixz reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the actual implementation until the tests are (hopefully) simpler.

@5ec1cff 5ec1cff requested a review from picnixz December 22, 2024 04:23
picnixz
picnixz reviewed Dec 22, 2024
View reviewed changes
@5ec1cff 5ec1cff changed the title GH-128131: Support fast forward seek in uncompressed unencrypted ZipExtFile GH-128131: Completely support random access of uncompressed unencrypted ZipExtFile Dec 22, 2024
picnixz
picnixz reviewed Dec 22, 2024
View reviewed changes
@5ec1cff 5ec1cff changed the title GH-128131: Completely support random access of uncompressed unencrypted ZipExtFile GH-128131: Completely support random access of uncompressed unencrypted files inside ZipFile Dec 22, 2024
@5ec1cff 5ec1cff changed the title GH-128131: Completely support random access of uncompressed unencrypted files inside ZipFile GH-128131: Completely support random read access of uncompressed unencrypted files in ZipFile Dec 22, 2024
@5ec1cff 5ec1cff requested a review from picnixz December 22, 2024 14:59
picnixz
picnixz previously requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address this comment: https://github.com/python/cpython/pull/128143/files#r1894920324.

@bedevere-app
Copy link

bedevere-app bot commented Dec 27, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@5ec1cff
Copy link
Contributor Author

5ec1cff commented Jan 2, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2025

Thanks for making the requested changes!

@jaraco: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from jaraco January 2, 2025 03:37
jaraco
jaraco approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the requested changes. This looks good. Thanks for the contrib!

@jaraco
Copy link
Member

jaraco commented Jan 20, 2025

The question is: should we treat this as a bug or a feature? it's half-half but I'm not a maintainer of this module so I don't really know. @jaraco WDYT?

Given that #27737 was intended to enable fast syncing and that this bug didn't exist prior to that PR, it feels like a regression and a bug.

@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 20, 2025
@jaraco jaraco merged commit dda02eb into python:main Jan 20, 2025
47 of 50 checks passed
@miss-islington-app
Copy link

Thanks @5ec1cff for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@5ec1cff @blurb-it
@picnixz @miss-islington
pythonGH-128131: Completely support random read access of uncompresse…
999d8fd 
…d unencrypted files in ZipFile (pythonGH-128143)

(cherry picked from commit dda02eb)

Co-authored-by: 5ec1cff <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@5ec1cff @blurb-it
@picnixz @miss-islington
pythonGH-128131: Completely support random read access of uncompresse…
69cffe9 
…d unencrypted files in ZipFile (pythonGH-128143)

(cherry picked from commit dda02eb)

Co-authored-by: 5ec1cff <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129091 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129092 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 20, 2025
jaraco pushed a commit that referenced this pull request Jan 20, 2025
@miss-islington @5ec1cff
@blurb-it @picnixz
[3.13] GH-128131: Completely support random read access of uncompress…
03b2ecf 
…ed unencrypted files in ZipFile (GH-128143) (#129091)

GH-128131: Completely support random read access of uncompressed unencrypted files in ZipFile (GH-128143)
(cherry picked from commit dda02eb)

Co-authored-by: 5ec1cff <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <[email protected]>
jaraco pushed a commit that referenced this pull request Jan 20, 2025
@miss-islington @5ec1cff
@blurb-it @picnixz
[3.12] GH-128131: Completely support random read access of uncompress…
03bce18 
…ed unencrypted files in ZipFile (GH-128143) (#129092)

GH-128131: Completely support random read access of uncompressed unencrypted files in ZipFile (GH-128143)
(cherry picked from commit dda02eb)

Co-authored-by: 5ec1cff <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <[email protected]>
@5ec1cff 5ec1cff deleted the 5ec1cff-patch-1 branch January 21, 2025 01:16
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@5ec1cff @blurb-it
@picnixz @srinivasreddy
pythonGH-128131: Completely support random read access of uncompresse…
6741255 
…d unencrypted files in ZipFile (python#128143)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danifus danifus danifus left review comments

@jaraco jaraco jaraco approved these changes

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@5ec1cff @picnixz @danifus @jaraco