-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-128349: use .. data::
instead of .. class::
for pre-defined decimal Context
objects
#128379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.. data::
instead of .. class::
for pre-defined decimal Context
objects
… 'standard' terminology
… 'standard' terminology
… 'standard' terminology
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge it, can you check that we never refer to those objects using the :class:
role across the docs? thanks in advance.
|
Those two need to be changed then. |
…endedContext in documentation
@picnixz @skirpichev Can you please review the changes now? I had checked within the doc library folder but now checked across complete doc folder. Let me know if any further changes/corrections are needed. |
@abkmystery, please avoid "update branch" button, unless you want to fix a merge conflict or to trigger CI run if your pr is old. |
@skirpichev Got it. Please review the changes now. |
@skirpichev Are there any further steps pending from me or will someone with authorization go through awaiting merge tagged PR and merge this? Asking as I am new to this and don't want to miss anything. Thanks |
Yes, you should wait a merge. |
Thanks @abkmystery for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ned decimal `Context` objects (pythonGH-128379) (cherry picked from commit 60c6518) Co-authored-by: abkmystery <[email protected]>
GH-128401 is a backport of this pull request to the 3.13 branch. |
…ned decimal `Context` objects (pythonGH-128379) (cherry picked from commit 60c6518) Co-authored-by: abkmystery <[email protected]>
GH-128402 is a backport of this pull request to the 3.12 branch. |
Thank you @abkmystery! Congratulations on your first contribution 🎊! |
…ned decimal `Context` objects (python#128379)
Closes gh-128349.
Updated
.. class:: BasicContext
to.. data:: BasicContext
to correctly represent it as a predefined context object, not a class.This ensures accurate documentation of the
decimal
module.📚 Documentation preview 📚: https://cpython-previews--128379.org.readthedocs.build/