gh-128427: Add uuid.NIL and uuid.MAX
#128429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wulian233
reviewed
Jan 2, 2025
picnixz
reviewed
Jan 3, 2025
Misc/NEWS.d/next/Library/2025-01-02-20-34-04.gh-issue-128427.onPoQZ.rst
Outdated
Show resolved
Hide resolved
|
By the way, avoid force-pushing in the future as it makes reviews harder; we eventually squash commits and write our own commit message (force-pushing is accepted in some cases only but those are quite rare (like fixing up a really wrong commit that should not be seen at all, or changing the committer's email/name to due CLA reasons)). |
ngnpope
commented
Jan 3, 2025
picnixz
reviewed
Jan 5, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
picnixz
approved these changes
Jan 6, 2025
picnixz
approved these changes
Jan 13, 2025
hugovk
approved these changes
Jan 13, 2025
| .. data:: NIL | ||
|
|
||
| A special form of UUID that is specified to have all 128 bits set to zero | ||
| according to :rfc:`RFC 9562, §5.9 <9562#section-5.9>`. |
There was a problem hiding this comment.
Linking directly to the section is helpful, perhaps we only need to mention the RFC number here? If so, we could update the same thing for uuid8 above.
Suggested change
| according to :rfc:`RFC 9562, §5.9 <9562#section-5.9>`. | |
| according to :rfc:`RFC 9562 <9562#section-5.9>`. |
| .. data:: MAX | ||
|
|
||
| A special form of UUID that is specified to have all 128 bits set to one | ||
| according to :rfc:`RFC 9562, §5.10 <9562#section-5.10>`. |
There was a problem hiding this comment.
Suggested change
| according to :rfc:`RFC 9562, §5.10 <9562#section-5.10>`. | |
| according to :rfc:`RFC 9562 <9562#section-5.10>`. |
encukou
approved these changes
Jan 27, 2025
|
Sure, let's merge. @ngnpope, thank you your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds constants for Nil and Max UUID formats as per RFC 9562.
📚 Documentation preview 📚: https://cpython-previews--128429.org.readthedocs.build/