gh-128703: Fix mimetypes.guess_type for empty Content-Type in registry #128854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
needs backport to 3.12
zooba
reviewed
Jan 17, 2025
zooba
reviewed
Jan 22, 2025
| @@ -0,0 +1,2 @@ | |||
| Fix :meth:`mimetypes.MimeTypes.guess_type` to use default mapping for empty | |||
There was a problem hiding this comment.
We document this as a function:
Suggested change
| Fix :meth:`mimetypes.MimeTypes.guess_type` to use default mapping for empty | |
| Fix :func:`mimetypes.guess_type` to use default mapping for empty |
(I think that's right, but check the output of the docs build if it fails again.)
There was a problem hiding this comment.
Sorry I just saw it. But, to be honest, I often can't tell which label to use for symbol references.
|
Thanks @rruuaanng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2025
…egistry (pythonGH-128854) (cherry picked from commit 303043f) Co-authored-by: RUANG (James Roy) <[email protected]>
|
GH-130121 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2025
…egistry (pythonGH-128854) (cherry picked from commit 303043f) Co-authored-by: RUANG (James Roy) <[email protected]>
|
GH-130122 is a backport of this pull request to the 3.12 branch. |
zooba
pushed a commit
that referenced
this pull request
Feb 14, 2025
GH-128854) (cherry picked from commit 303043f) Co-authored-by: RUANG (James Roy) <[email protected]>
zooba
pushed a commit
that referenced
this pull request
Feb 17, 2025
GH-128854) (cherry picked from commit 303043f) Co-authored-by: RUANG (James Roy) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.